Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create-mud): set store address in PostDeploy script #1817

Merged
merged 4 commits into from
Oct 24, 2023

Conversation

ryosevenf
Copy link
Contributor

@ryosevenf ryosevenf commented Oct 24, 2023

fixes #1719

@ryosevenf ryosevenf requested review from alvrs and holic as code owners October 24, 2023 05:31
@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2023

🦋 Changeset detected

Latest commit: 31a65d0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
create-mud Patch
@latticexyz/abi-ts Patch
@latticexyz/block-logs-stream Patch
@latticexyz/cli Patch
@latticexyz/common Patch
@latticexyz/config Patch
@latticexyz/dev-tools Patch
@latticexyz/ecs-browser Patch
@latticexyz/faucet Patch
@latticexyz/gas-report Patch
@latticexyz/network Patch
@latticexyz/noise Patch
@latticexyz/phaserx Patch
@latticexyz/protocol-parser Patch
@latticexyz/react Patch
@latticexyz/recs Patch
@latticexyz/schema-type Patch
@latticexyz/services Patch
@latticexyz/solecs Patch
solhint-config-mud Patch
solhint-plugin-mud Patch
@latticexyz/std-client Patch
@latticexyz/std-contracts Patch
@latticexyz/store-cache Patch
@latticexyz/store-indexer Patch
@latticexyz/store-sync Patch
@latticexyz/store Patch
@latticexyz/utils Patch
@latticexyz/world-modules Patch
@latticexyz/world Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ryosevenf ryosevenf changed the title Set store address in PostDeploy script fix(create-mud): set store address in PostDeploy script Oct 24, 2023
@ryosevenf ryosevenf force-pushed the set-store-address-in-postdeploy branch from 020785f to 8154958 Compare October 24, 2023 05:41
holic
holic previously approved these changes Oct 24, 2023
Copy link
Member

@holic holic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@alvrs
Copy link
Member

alvrs commented Oct 24, 2023

I think we might have to import StoreSwitch first

import { StoreSwitch } from "@latticexyz/store/src/StoreSwitch.sol";

@@ -12,6 +12,9 @@ import { ChatNamespacedSystem } from "../src/systems/ChatNamespacedSystem.sol";

contract PostDeploy is Script {
function run(address worldAddress) external {
// Specify a store so that you can use tables directly in PostDeploy
StoreSwitch.setStoreAddress(worldAddress);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this is missing an import of StoreSwitch

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, fixed it. 🙏

@ryosevenf ryosevenf requested a review from holic October 24, 2023 11:20
@holic holic merged commit c5148da into latticexyz:main Oct 24, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PostDeploy should set store address
3 participants