Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(world-modules): add totalSupply table, use OpenZeppelin IERC20 #1797

Merged
merged 4 commits into from
Oct 19, 2023

Conversation

yonadaa
Copy link
Contributor

@yonadaa yonadaa commented Oct 19, 2023

Imports the IERC20 interfaces from @openzeppelin/contracts for code reuse.

I also moved totalSupply into it's own table as it is not used in ERC721 and we might want to share the Metadata table with that module.

@changeset-bot
Copy link

changeset-bot bot commented Oct 19, 2023

⚠️ No Changeset found

Latest commit: e22b7e3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@yonadaa yonadaa marked this pull request as ready for review October 19, 2023 16:24
@yonadaa yonadaa requested review from alvrs and holic as code owners October 19, 2023 16:24
@alvrs alvrs changed the title Add totalSupply table, use Openzeppelin ERC20 feat(world-modules): add totalSupply table, use OpenZeppelin IERC20 Oct 19, 2023
@alvrs alvrs merged commit 6fea4c9 into alvrs/erc20 Oct 19, 2023
9 of 10 checks passed
@alvrs alvrs deleted the yonadaaa/erc20-tweaks branch October 19, 2023 18:55
@alvrs alvrs restored the yonadaaa/erc20-tweaks branch October 19, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants