feat(cli): remove forge clean from deploy #1759
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1750
I think we were cleaning before when we had artifacts checked into git and we didn't want to leave around old artifacts, and when we were using typechain to generate types. I don't think this is as concerning anymore now that these are all in a gitignored directory and abi-ts is simple+fast.
I considered replacing
forge clean
with justrm -rf out
but removing build files creates weird race conditions in Sky Strife deploy + start up, where a process has a chance of starting up while a redeploy is happening and then immediately fails because it can't find e.g.out/IWorld.sol/IWorld.abi.json
.If folks want a one-time, pre-deploy clean, they can add that to their script e.g.
forge clean && mud deploy