Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): remove forge clean from deploy #1759

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Conversation

holic
Copy link
Member

@holic holic commented Oct 12, 2023

closes #1750

I think we were cleaning before when we had artifacts checked into git and we didn't want to leave around old artifacts, and when we were using typechain to generate types. I don't think this is as concerning anymore now that these are all in a gitignored directory and abi-ts is simple+fast.

I considered replacing forge clean with just rm -rf out but removing build files creates weird race conditions in Sky Strife deploy + start up, where a process has a chance of starting up while a redeploy is happening and then immediately fails because it can't find e.g. out/IWorld.sol/IWorld.abi.json.

If folks want a one-time, pre-deploy clean, they can add that to their script e.g. forge clean && mud deploy

@changeset-bot
Copy link

changeset-bot bot commented Oct 12, 2023

🦋 Changeset detected

Latest commit: 69f87ac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@latticexyz/cli Major
@latticexyz/abi-ts Major
@latticexyz/block-logs-stream Major
@latticexyz/common Major
@latticexyz/config Major
create-mud Major
@latticexyz/dev-tools Major
@latticexyz/ecs-browser Major
@latticexyz/faucet Major
@latticexyz/gas-report Major
@latticexyz/network Major
@latticexyz/noise Major
@latticexyz/phaserx Major
@latticexyz/protocol-parser Major
@latticexyz/react Major
@latticexyz/recs Major
@latticexyz/schema-type Major
@latticexyz/services Major
@latticexyz/solecs Major
solhint-config-mud Major
solhint-plugin-mud Major
@latticexyz/std-client Major
@latticexyz/std-contracts Major
@latticexyz/store-cache Major
@latticexyz/store-indexer Major
@latticexyz/store-sync Major
@latticexyz/store Major
@latticexyz/utils Major
@latticexyz/world-modules Major
@latticexyz/world Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@holic holic marked this pull request as ready for review October 12, 2023 13:26
@holic holic requested a review from alvrs as a code owner October 12, 2023 13:26
alvrs
alvrs previously approved these changes Oct 12, 2023
Copy link
Member

@alvrs alvrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add a changeset

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deploy: consider just clearing out dir rather than forge clean
2 participants