Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): deploy failing to find user modules #1703

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

codynhat
Copy link
Contributor

@codynhat codynhat commented Oct 5, 2023

When adding a custom user module to mud.config.ts, I am receiving the following error when deploying:

MUD dev-contracts watcher failed to deploy config or contracts changes

MUDError: Error reading file at out/0.sol/0.json

It appears the deploy script cannot find the compiled contract of my module, because it is using the array index (0) as the module name instead of the name field.

@codynhat codynhat requested review from alvrs and holic as code owners October 5, 2023 00:12
@changeset-bot
Copy link

changeset-bot bot commented Oct 5, 2023

⚠️ No Changeset found

Latest commit: 8145f8c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codynhat codynhat changed the title fix(cli): Deploy failing to find user modules fix(cli): deploy failing to find user modules Oct 5, 2023
@holic
Copy link
Member

holic commented Oct 5, 2023

good find, thank you!

@holic holic merged commit e3d2aef into latticexyz:main Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants