-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gas-report): add more logs to stdin piping #1694
Conversation
alvrs
commented
Oct 3, 2023
- minor addition to pass through logs received via stdin (since the test command can be long running it's useful to know if the tests are still running or the gas reporter is already parsing)
🦋 Changeset detectedLatest commit: f4753c1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
packages/gas-report/ts/index.ts
Outdated
data += chunk; | ||
}); | ||
|
||
process.stdin.on("end", () => { | ||
console.log("Done waiting for stdin"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
process.stdin
is a stream so you could also
process.stdin.pipe(process.stdout)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and could prob lean on a generic stream package like https://github.com/stream-utils/stream-to-array
const stdin = (await streamToArray(process.stdin)).map((chunk) => Buffer.from(chunk).toString('utf8'))