refactor(common): move createContract's internal write logic to writeContract

[holic]

closes #1554

This matches how viem abstracts this behavior and lets us use writeContract without having to create a contract instance via createContract (planning to use this in #1625)

[changeset-bot]

🦋 Changeset detected

Latest commit: 66c4e4b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages

Name	Type
@latticexyz/common	Major
@latticexyz/block-logs-stream	Major
@latticexyz/cli	Major
@latticexyz/config	Major
@latticexyz/dev-tools	Major
@latticexyz/protocol-parser	Major
@latticexyz/store-indexer	Major
@latticexyz/store-sync	Major
@latticexyz/store	Major
@latticexyz/world-modules	Major
@latticexyz/world	Major
@latticexyz/react	Major
@latticexyz/abi-ts	Major
create-mud	Major
@latticexyz/ecs-browser	Major
@latticexyz/faucet	Major
@latticexyz/gas-report	Major
@latticexyz/network	Major
@latticexyz/noise	Major
@latticexyz/phaserx	Major
@latticexyz/recs	Major
@latticexyz/schema-type	Major
@latticexyz/services	Major
@latticexyz/solecs	Major
solhint-config-mud	Major
solhint-plugin-mud	Major
@latticexyz/std-client	Major
@latticexyz/std-contracts	Major
@latticexyz/store-cache	Major
@latticexyz/utils	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
mud-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 3, 2023 3:46pm

[holic]

Slightly different approach to what we've been doing in the past to avoid a breaking change. We can just remove this in a future version as a breaking change, potentially batching with other breaking changes.

I kinda like the deprecate-then-break pattern so playing with it here.

[alvrs]

i like the new more modular approach. For context, was there something in the previous createContract approach that was blocking using it in #1625?

[holic]

i like the new more modular approach. For context, was there something in the previous createContract approach that was blocking using it in #1625?

not necessarily blocking, just feels a bit cleaner, esp if we eventually have to write to multiple contracts

and ultimately trying to move our code to the more modular/tree-shakeable approach that viem suggests (#1307)