Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(store,world): move around interfaces and base contracts #1602

Merged
merged 8 commits into from
Sep 25, 2023

Conversation

holic
Copy link
Member

@holic holic commented Sep 25, 2023

torn on whether to put interface files into an interfaces dir (I tend to prefer not doing this but we do this in world already and I'd like to be consistent)

@changeset-bot
Copy link

changeset-bot bot commented Sep 25, 2023

🦋 Changeset detected

Latest commit: 610d37a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@latticexyz/store Major
@latticexyz/world Major
@latticexyz/cli Major
@latticexyz/dev-tools Major
@latticexyz/react Major
@latticexyz/store-indexer Major
@latticexyz/store-sync Major
@latticexyz/world-modules Major
@latticexyz/abi-ts Major
@latticexyz/block-logs-stream Major
@latticexyz/common Major
@latticexyz/config Major
create-mud Major
@latticexyz/ecs-browser Major
@latticexyz/faucet Major
@latticexyz/gas-report Major
@latticexyz/network Major
@latticexyz/noise Major
@latticexyz/phaserx Major
@latticexyz/protocol-parser Major
@latticexyz/recs Major
@latticexyz/schema-type Major
@latticexyz/services Major
@latticexyz/solecs Major
solhint-config-mud Major
solhint-plugin-mud Major
@latticexyz/std-client Major
@latticexyz/std-contracts Major
@latticexyz/store-cache Major
@latticexyz/utils Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@holic holic changed the title WIP move some events and version around refactor(store,world): move around interfaces and base contracts Sep 25, 2023
@holic holic marked this pull request as ready for review September 25, 2023 15:15
@holic holic requested review from alvrs and dk1a as code owners September 25, 2023 15:15
@alvrs
Copy link
Member

alvrs commented Sep 25, 2023

torn on whether to put interface files into an interfaces dir (I tend to prefer not doing this but we do this in world already and I'd like to be consistent)

Agree with the point on consistency, moved tables to the same folder structure in both for the same reason

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants