-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(world,world-modules): move optional modules from world
to world-modules
package
#1591
Conversation
🦋 Changeset detectedLatest commit: 12e6f1c The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
.changeset/unlucky-cups-fetch.md
Outdated
@@ -0,0 +1,8 @@ | |||
--- | |||
"@latticexyz/cli": path |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"@latticexyz/cli": path | |
"@latticexyz/cli": patch |
.changeset/pre.json
Outdated
@@ -29,7 +29,8 @@ | |||
"@latticexyz/store-sync": "1.42.0", | |||
"@latticexyz/utils": "1.42.0", | |||
"@latticexyz/world": "1.42.0", | |||
"@latticexyz/abi-ts": "2.0.0-next.5" | |||
"@latticexyz/abi-ts": "2.0.0-next.5", | |||
"@latticexyz/world-modules": "1.42.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iirc I didn't have to add this manually for abi-ts, and the reason abi-ts has the version that it has is because the next prerelease set it for us
"tsx": "^3.12.6", | ||
"vitest": "0.31.4" | ||
}, | ||
"gitHead": "914a1e0ae4a573d685841ca2ea921435057deb8f" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"gitHead": "914a1e0ae4a573d685841ca2ea921435057deb8f" | |
"publishConfig": { | |
"access": "public" | |
}, | |
"gitHead": "914a1e0ae4a573d685841ca2ea921435057deb8f" |
@@ -63,7 +63,6 @@ | |||
"ejs": "^3.1.8", | |||
"forge-std": "https://github.com/foundry-rs/forge-std.git#74cfb77e308dd188d2f58864aaf44963ae6b88b1", | |||
"glob": "^8.0.3", | |||
"hardhat": "^2.10.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iirc this was needed for solhint? but if not, very happy to get rid of this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems like solhint
does the same with and without hardhat, interestingly it doesn't find actual errors (like missing semicolon) in either case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm aside from a few small things
2225c55
to
74811f0
Compare
fba3c54
to
522d139
Compare
Co-authored-by: Kevin Ingersoll <[email protected]>
522d139
to
12e6f1c
Compare
Moving all modules except the core module from
world
toworld-modules
to slim down theworld
package