Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(world,world-modules): move optional modules from world to world-modules package #1591

Merged
merged 8 commits into from
Sep 25, 2023

Conversation

alvrs
Copy link
Member

@alvrs alvrs commented Sep 24, 2023

Moving all modules except the core module from world to world-modules to slim down the world package

@changeset-bot
Copy link

changeset-bot bot commented Sep 24, 2023

🦋 Changeset detected

Latest commit: 12e6f1c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@latticexyz/cli Major
@latticexyz/world Major
@latticexyz/world-modules Major
@latticexyz/dev-tools Major
@latticexyz/store-sync Major
@latticexyz/store-indexer Major
@latticexyz/abi-ts Major
@latticexyz/block-logs-stream Major
@latticexyz/common Major
@latticexyz/config Major
create-mud Major
@latticexyz/ecs-browser Major
@latticexyz/faucet Major
@latticexyz/gas-report Major
@latticexyz/network Major
@latticexyz/noise Major
@latticexyz/phaserx Major
@latticexyz/protocol-parser Major
@latticexyz/react Major
@latticexyz/recs Major
@latticexyz/schema-type Major
@latticexyz/services Major
@latticexyz/solecs Major
solhint-config-mud Major
solhint-plugin-mud Major
@latticexyz/std-client Major
@latticexyz/std-contracts Major
@latticexyz/store-cache Major
@latticexyz/store Major
@latticexyz/utils Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -0,0 +1,8 @@
---
"@latticexyz/cli": path
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"@latticexyz/cli": path
"@latticexyz/cli": patch

@@ -29,7 +29,8 @@
"@latticexyz/store-sync": "1.42.0",
"@latticexyz/utils": "1.42.0",
"@latticexyz/world": "1.42.0",
"@latticexyz/abi-ts": "2.0.0-next.5"
"@latticexyz/abi-ts": "2.0.0-next.5",
"@latticexyz/world-modules": "1.42.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iirc I didn't have to add this manually for abi-ts, and the reason abi-ts has the version that it has is because the next prerelease set it for us

"tsx": "^3.12.6",
"vitest": "0.31.4"
},
"gitHead": "914a1e0ae4a573d685841ca2ea921435057deb8f"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"gitHead": "914a1e0ae4a573d685841ca2ea921435057deb8f"
"publishConfig": {
"access": "public"
},
"gitHead": "914a1e0ae4a573d685841ca2ea921435057deb8f"

@@ -63,7 +63,6 @@
"ejs": "^3.1.8",
"forge-std": "https://github.com/foundry-rs/forge-std.git#74cfb77e308dd188d2f58864aaf44963ae6b88b1",
"glob": "^8.0.3",
"hardhat": "^2.10.2",
Copy link
Member

@holic holic Sep 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iirc this was needed for solhint? but if not, very happy to get rid of this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems like solhint does the same with and without hardhat, interestingly it doesn't find actual errors (like missing semicolon) in either case

holic
holic previously approved these changes Sep 24, 2023
Copy link
Member

@holic holic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm aside from a few small things

@alvrs alvrs force-pushed the alvrs/namespace-delegation-control branch from 2225c55 to 74811f0 Compare September 24, 2023 23:25
Base automatically changed from alvrs/namespace-delegation-control to main September 24, 2023 23:33
@alvrs alvrs dismissed holic’s stale review September 24, 2023 23:33

The base branch was changed.

Co-authored-by: Kevin Ingersoll <[email protected]>
@alvrs alvrs force-pushed the alvrs/world-modules branch from 522d139 to 12e6f1c Compare September 25, 2023 00:01
@alvrs alvrs merged commit 251170e into main Sep 25, 2023
@alvrs alvrs deleted the alvrs/world-modules branch September 25, 2023 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants