Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(store): change argument order on Store_SpliceDynamicData and hooks for consistency #1589

Merged
merged 4 commits into from
Sep 24, 2023

Conversation

alvrs
Copy link
Member

@alvrs alvrs commented Sep 24, 2023

PackedCounter encodedLength is now always the argument before bytes dynamicData

@changeset-bot
Copy link

changeset-bot bot commented Sep 24, 2023

🦋 Changeset detected

Latest commit: b8b1aaf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 29 packages
Name Type
@latticexyz/store Major
@latticexyz/cli Major
@latticexyz/dev-tools Major
@latticexyz/react Major
@latticexyz/store-indexer Major
@latticexyz/store-sync Major
@latticexyz/world Major
@latticexyz/abi-ts Major
@latticexyz/block-logs-stream Major
@latticexyz/common Major
@latticexyz/config Major
create-mud Major
@latticexyz/ecs-browser Major
@latticexyz/faucet Major
@latticexyz/gas-report Major
@latticexyz/network Major
@latticexyz/noise Major
@latticexyz/phaserx Major
@latticexyz/protocol-parser Major
@latticexyz/recs Major
@latticexyz/schema-type Major
@latticexyz/services Major
@latticexyz/solecs Major
solhint-config-mud Major
solhint-plugin-mud Major
@latticexyz/std-client Major
@latticexyz/std-contracts Major
@latticexyz/store-cache Major
@latticexyz/utils Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

dk1a
dk1a previously approved these changes Sep 24, 2023
uint40 deleteCount,
+ PackedCounter encodedLengths,
bytes data,
- PackedCounter encodedLengths
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lermchair hates us

holic
holic previously approved these changes Sep 24, 2023
Base automatically changed from alvrs/resource-type-table to main September 24, 2023 23:09
@alvrs alvrs dismissed stale reviews from holic and dk1a September 24, 2023 23:09

The base branch was changed.

@alvrs alvrs force-pushed the alvrs/reorder-event branch from fc8f051 to b8b1aaf Compare September 24, 2023 23:11
@alvrs alvrs merged commit f9f9609 into main Sep 24, 2023
@alvrs alvrs deleted the alvrs/reorder-event branch September 24, 2023 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants