feat(store,world): use user-types for ResourceId, FieldLayout and Schema in table libraries
#1586
Conversation
🦋 Changeset detectedLatest commit: 55ddc6d The changes in this PR will be included in the next version bump. This PR includes changesets to release 29 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
alvrs
force-pushed
the
alvrs/resource-type-table
branch
from
50f79c7 to
26c3b9a
Compare
| "gasUsed": 10240 | ||
| "gasUsed": 5609 |
There was a problem hiding this comment.
these gas changes come from not loading the _tableId and _keyTuple from storage in the gas test
There was a problem hiding this comment.
same for all tests or just this one? I noticed some other gas improvements below
There was a problem hiding this comment.
wrapping/unwrapping in itself should not significantly impact gas, so i think most of the gas variation in here comes from the changed gas tests
alvrs
force-pushed
the
alvrs/resource-type-table
branch
from
5738256 to
65febd5
Compare
| // TODO: adjust when schemas are automatically resolved | ||
| export const schemasTable = { | ||
| ...storeConfig.tables.Tables, | ||
| valueSchema: resolveUserTypes(storeConfig.tables.Tables.valueSchema, storeConfig.userTypes), | ||
| }; | ||
|
|
There was a problem hiding this comment.
kind of annoying, but we need this workaround for now to land the contract changes (until we have a better way to resolve the user type config with strong types)
There was a problem hiding this comment.
hopefully coming in #1561 (but still a lot of work left to do)
| ResourceId tableId = _tableId; | ||
| bytes32[] memory keyTuple = _keyTuple; |
There was a problem hiding this comment.
we could use immutable too, it's about as convenient as storage, but without the gas overhead. It's only useful for constant-like values tho
alvrs
dismissed stale reviews from holic and dk1a
The base branch was changed.
Thanks to #1566 we can now use the real user-types in table libraries and don't need to manually
wrap/unwrapeverywhere