feat(faucet): add faucet service #1517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fbdb500 The changes in this PR will be included in the next version bump. This PR includes changesets to release 29 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
alvrs
previously approved these changes
Sep 16, 2023
|
amazing! |
|
(let's add a changeset with minimal usage instructions before merging) |
alvrs
reviewed
Sep 16, 2023
Comment on lines
+52
to
+55
| const drip = async () => { | ||
| console.log("dripping"); | ||
| const tx = await faucet.drip.mutate({ address: burnerAccount.address }); | ||
| console.log("got drip", tx); |
There was a problem hiding this comment.
should we still only do this if the balance is below a certain threshold?
There was a problem hiding this comment.
this is just the example app, but yes the templates should once we get this wired up to k8s
There was a problem hiding this comment.
or better yet, consider putting the threshold in the faucet itself? so folks don't try to load up
alvrs
approved these changes
Sep 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last thing left in services package before we can 🔥