Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(store-indexer): subscribe postgres indexer to stream #1514

Merged
merged 4 commits into from
Sep 16, 2023

Conversation

holic
Copy link
Member

@holic holic commented Sep 16, 2023

fixes #1507

right now we're just subscribing to the stream used to log "all caught up", which closes on the first emission, which means the postgres indexer ~stops after it catches up

when building the postgres indexer, I modeled it off of sqlite indexer but made some changes/improvements and missed the fact that I still needed to subscribe to original stream (blockStorageOperations$) because we're using a plain createStoreSync rather than syncToPostgres (so we can access the postgres storage adapter earlier in the code).

@changeset-bot
Copy link

changeset-bot bot commented Sep 16, 2023

🦋 Changeset detected

Latest commit: 62a41a8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 29 packages
Name Type
@latticexyz/store-indexer Patch
@latticexyz/abi-ts Patch
@latticexyz/block-logs-stream Patch
@latticexyz/cli Patch
@latticexyz/common Patch
@latticexyz/config Patch
create-mud Patch
@latticexyz/dev-tools Patch
@latticexyz/ecs-browser Patch
@latticexyz/faucet Patch
@latticexyz/gas-report Patch
@latticexyz/network Patch
@latticexyz/noise Patch
@latticexyz/phaserx Patch
@latticexyz/protocol-parser Patch
@latticexyz/react Patch
@latticexyz/recs Patch
@latticexyz/schema-type Patch
@latticexyz/services Patch
@latticexyz/solecs Patch
solhint-config-mud Patch
solhint-plugin-mud Patch
@latticexyz/std-client Patch
@latticexyz/std-contracts Patch
@latticexyz/store-cache Patch
@latticexyz/store-sync Patch
@latticexyz/store Patch
@latticexyz/utils Patch
@latticexyz/world Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@holic holic marked this pull request as ready for review September 16, 2023 11:30
@holic holic requested a review from alvrs as a code owner September 16, 2023 11:30
alvrs
alvrs previously approved these changes Sep 16, 2023
@holic holic merged commit ed07018 into main Sep 16, 2023
@holic holic deleted the holic/postgres-indexer-stuck branch September 16, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The indexer gets stuck with PostgreSQL
2 participants