feat(world): add CallBatchSystem to core module

packages/world/mud.config.ts

@@ -200,6 +200,7 @@ export default mudConfig({
     // TODO: Move optional modules into a separate package
     // (see https://github.com/latticexyz/mud/pull/584)
     "UniqueEntitySystem",
+    "BatchCallSystem",
 
     // Worldgen currently does not support systems inheriting logic
     // from other contracts, so all parts of CoreSystem are named

packages/world/src/interfaces/IBatchCallSystem.sol

@@ -0,0 +1,6 @@
+// SPDX-License-Identifier: MIT
+pragma solidity >=0.8.0;
+
+interface IBatchCallSystem {
+  function batchCall_system_batchCall(bytes32[] memory resourceSelectors, bytes[] memory funcSelectorAndArgs) external;
+}

packages/world/src/modules/batchcall/BatchCallModule.sol

@@ -0,0 +1,31 @@
+// SPDX-License-Identifier: MIT
+pragma solidity >=0.8.0;
+
+import { IBaseWorld } from "../../interfaces/IBaseWorld.sol";
+
+import { Module } from "../../Module.sol";
+import { ResourceSelector } from "../../ResourceSelector.sol";
+
+import { BatchCallSystem } from "./BatchCallSystem.sol";
+
+import { NAMESPACE, MODULE_NAME, SYSTEM_NAME } from "./constants.sol";
+
+contract BatchCallModule is Module {
+  BatchCallSystem private immutable batchCallSystem = new BatchCallSystem();
+
+  function getName() public pure returns (bytes16) {
+    return MODULE_NAME;
+  }
+
+  function installRoot(bytes memory args) public {
+    install(args);
+  }
+
+  function install(bytes memory) public {
+    IBaseWorld world = IBaseWorld(_world());
+
+    world.registerSystem(ResourceSelector.from(NAMESPACE, SYSTEM_NAME), batchCallSystem, true);
+
+    world.registerFunctionSelector(ResourceSelector.from(NAMESPACE, SYSTEM_NAME), "batchCall", "(bytes32[],bytes[])");
+  }
+}

packages/world/src/modules/batchcall/BatchCallSystem.sol

@@ -0,0 +1,14 @@
+// SPDX-License-Identifier: MIT
+pragma solidity >=0.8.0;
+import { System } from "../../System.sol";
+import { IBaseWorld } from "../../interfaces/IBaseWorld.sol";
+
+contract BatchCallSystem is System {
+  function batchCall(bytes32[] memory resourceSelectors, bytes[] memory funcSelectorAndArgss) public {
+    IBaseWorld world = IBaseWorld(_world());
+
+    for (uint256 i; i < resourceSelectors.length; i++) {
+      world.callFrom(_msgSender(), resourceSelectors[i], funcSelectorAndArgss[i]);
+    }
+  }
+}

packages/world/src/modules/batchcall/constants.sol

@@ -0,0 +1,6 @@
+// SPDX-License-Identifier: MIT
+pragma solidity >=0.8.0;
+
+bytes16 constant NAMESPACE = bytes16("batchCall");
+bytes16 constant MODULE_NAME = bytes16("batchCall.m");
+bytes16 constant SYSTEM_NAME = bytes16("system");

packages/world/test/BatchCallModule.t.sol

@@ -0,0 +1,89 @@
+// SPDX-License-Identifier: MIT
+pragma solidity >=0.8.0;
+
+import { Test } from "forge-std/Test.sol";
+import { GasReporter } from "@latticexyz/gas-report/src/GasReporter.sol";
+
+import { ROOT_NAMESPACE, UNLIMITED_DELEGATION } from "../src/constants.sol";
+import { World } from "../src/World.sol";
+import { IBaseWorld } from "../src/interfaces/IBaseWorld.sol";
+import { IWorldErrors } from "../src/interfaces/IWorldErrors.sol";
+
+import { CoreModule } from "../src/modules/core/CoreModule.sol";
+import { BatchCallModule } from "../src/modules/batchcall/BatchCallModule.sol";
+import { IBatchCallSystem } from "../src/interfaces/IBatchCallSystem.sol";
+
+import { NAMESPACE } from "../src/modules/batchcall/constants.sol";
+import { ResourceSelector } from "../src/ResourceSelector.sol";
+
+import { WorldTestSystem } from "./World.t.sol";
+
+contract BatchCallModuleTest is Test, GasReporter {
+  using ResourceSelector for bytes32;
+
+  IBaseWorld world;
+  BatchCallModule batchCallModule = new BatchCallModule();
+
+  function setUp() public {
+    world = IBaseWorld(address(new World()));
+    world.initialize(new CoreModule());
+  }
+
+  function testInstall() public {
+    startGasReport("install batch call module");
+    world.installModule(batchCallModule, new bytes(0));
+    endGasReport();
+
+    // Register a new system
+    WorldTestSystem system = new WorldTestSystem();
+    bytes32 resourceSelector = ResourceSelector.from("namespace", "testSystem");
+
+    world.registerSystem(resourceSelector, system, false);
+
+    bytes32[] memory resourceSelectors = new bytes32[](1);
+    bytes[] memory funcSelectorAndArgss = new bytes[](1);
+
+    resourceSelectors[0] = resourceSelector;
+    funcSelectorAndArgss[0] = abi.encodeWithSelector(WorldTestSystem.getStoreAddress.selector);
+
+    // TODO: do not hardcode this
+    address delegatee = 0x104fBc016F4bb334D775a19E8A6510109AC63E00;
+
+    vm.expectRevert(abi.encodeWithSelector(IWorldErrors.DelegationNotFound.selector, address(this), delegatee));
+    IBatchCallSystem(address(world)).batchCall_system_batchCall(resourceSelectors, funcSelectorAndArgss);
+
+    // Register an unlimited delegation
+    world.registerDelegation(delegatee, UNLIMITED_DELEGATION, new bytes(0));
+
+    IBatchCallSystem(address(world)).batchCall_system_batchCall(resourceSelectors, funcSelectorAndArgss);
+  }
+
+  function testInstallRoot() public {
+    startGasReport("installRoot batch call module");
+    world.installRootModule(batchCallModule, new bytes(0));
+    endGasReport();
+
+    // Register a new system
+    WorldTestSystem system = new WorldTestSystem();
+    bytes32 resourceSelector = ResourceSelector.from("namespace", "testSystem");
+
+    world.registerSystem(resourceSelector, system, false);
+
+    bytes32[] memory resourceSelectors = new bytes32[](1);
+    bytes[] memory funcSelectorAndArgss = new bytes[](1);
+
+    resourceSelectors[0] = resourceSelector;
+    funcSelectorAndArgss[0] = abi.encodeWithSelector(WorldTestSystem.getStoreAddress.selector);
+
+    // TODO: do not hardcode this
+    address delegatee = 0x104fBc016F4bb334D775a19E8A6510109AC63E00;
+
+    vm.expectRevert(abi.encodeWithSelector(IWorldErrors.DelegationNotFound.selector, address(this), delegatee));
+    IBatchCallSystem(address(world)).batchCall_system_batchCall(resourceSelectors, funcSelectorAndArgss);
+
+    // Register an unlimited delegation
+    world.registerDelegation(delegatee, UNLIMITED_DELEGATION, new bytes(0));
+
+    IBatchCallSystem(address(world)).batchCall_system_batchCall(resourceSelectors, funcSelectorAndArgss);
+  }
+}