Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(common,create-mud): route contract calls to use callFrom #1466

Closed
wants to merge 35 commits into from
Closed

feat(common,create-mud): route contract calls to use callFrom #1466

wants to merge 35 commits into from

Conversation

y77cao
Copy link
Contributor

@y77cao y77cao commented Sep 13, 2023

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Sep 13, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: c7d0c3f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@holic holic changed the title Route all contract calls to use callFrom feat(common,create-mud): all contract calls to use callFrom Sep 13, 2023
@holic holic changed the title feat(common,create-mud): all contract calls to use callFrom feat(common,create-mud): route contract calls to use callFrom Sep 13, 2023
@holic holic mentioned this pull request Sep 14, 2023
Merged
holic
holic reviewed Sep 18, 2023
View reviewed changes
packages/store-sync/src/recs/syncToRecs.ts Outdated
abi: IStoreAbi,
functionName: "getRecord",
args: [components.FunctionSelectors.id as Hex, [entity as Hex], encodedFieldLayout],
})) as Hex;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we have to cast this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for args - these are required to have 0x${string} type as inferred from the abi, but the id and entity are both string so I casted it to a stricter type here

for selectorRecord - don't really need to cast that. Will update

@y77cao y77cao marked this pull request as ready for review September 18, 2023 21:12
@y77cao y77cao requested a review from alvrs as a code owner September 18, 2023 21:12
@y77cao y77cao requested a review from holic September 18, 2023 21:13
@holic
Copy link
Member

holic commented Aug 15, 2024

closing as we now have a callFrom viem action/decorator

@holic holic closed this Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holic holic holic left review comments

@alvrs alvrs Awaiting requested review from alvrs alvrs is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@y77cao @holic