Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(create-mud): explain boilerplate in templates #1427

Merged
merged 38 commits into from
Sep 12, 2023

Conversation

qbzzt
Copy link
Contributor

@qbzzt qbzzt commented Sep 8, 2023

This replaces #1401 , putting the explanation with the code.

After this is approved I'll propagate the changes to the three other templates.

@changeset-bot
Copy link

changeset-bot bot commented Sep 8, 2023

⚠️ No Changeset found

Latest commit: 51243a1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@qbzzt
Copy link
Contributor Author

qbzzt commented Sep 9, 2023

@holic , thank you for the review. I put in most of your comments, and where I didn't explained why so you can argue with me. Ready for rereview.

@qbzzt qbzzt requested a review from holic September 12, 2023 13:01
@qbzzt qbzzt requested a review from holic September 12, 2023 14:01
@qbzzt
Copy link
Contributor Author

qbzzt commented Sep 12, 2023

I think all nits have been crunched.

holic
holic previously approved these changes Sep 12, 2023
Copy link
Member

@holic holic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Linter is complaining. Just need to run pnpm prettier from the mud root to fix and commit to make tests happy.

@qbzzt
Copy link
Contributor Author

qbzzt commented Sep 12, 2023 via email

@qbzzt qbzzt merged commit d2c8488 into main Sep 12, 2023
@qbzzt qbzzt deleted the 230907-client-boilerplate-comments branch September 12, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants