-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(create-mud): explain boilerplate in templates #1427
Conversation
Still need to do deployments to Lattice's test blockchain
…/mud into 230825-deploy2testnet
|
templates/vanilla/packages/client/src/mud/createClientComponents.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Kevin Ingersoll <[email protected]>
@holic , thank you for the review. I put in most of your comments, and where I didn't explained why so you can argue with me. Ready for rereview. |
Co-authored-by: Kevin Ingersoll <[email protected]>
I think all nits have been crunched. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Linter is complaining. Just need to run pnpm prettier
from the mud root to fix and commit to make tests happy.
I will do that in a bit. When the linter is happy I will merge and do a
little dance ;-)
…On Tue, Sep 12, 2023, 10:54 AM Kevin Ingersoll ***@***.***> wrote:
***@***.**** approved this pull request.
Looks great!
Linter is complaining. Just need to run pnpm prettier from the mud root
to fix and commit to make tests happy.
—
Reply to this email directly, view it on GitHub
<#1427 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADBCGGMP22PR3JHVOQ4FENDX2CAU7ANCNFSM6AAAAAA4QP5ITY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This replaces #1401 , putting the explanation with the code.
After this is approved I'll propagate the changes to the three other templates.