Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: only start up indexer for online tests #1322

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Conversation

holic
Copy link
Member

@holic holic commented Aug 17, 2023

CI is flaky when attempting to start then immediately kill the indexer. This updates tests to only start the indexer when we actually want to use it.

@changeset-bot
Copy link

changeset-bot bot commented Aug 17, 2023

⚠️ No Changeset found

Latest commit: 69c61eb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@holic holic marked this pull request as ready for review August 17, 2023 11:07
@holic holic requested a review from alvrs as a code owner August 17, 2023 11:07
@holic holic requested a review from dk1a August 17, 2023 11:10
@holic holic merged commit 5a6e164 into main Aug 17, 2023
@holic holic deleted the holic/e2e-indexer-fail branch August 17, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants