refactor(store): use _keyTupleDefinition in encodeKeyTuple #1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dk1a
force-pushed
the
dk1a/encodeKeyTuple
branch
from
0d7c609 to
40e7f83
Compare
alvrs
reviewed
Aug 16, 2023
Comment on lines
-138
to
+140
| function encodeKeyTuple(${renderArguments([_typedKeyArgs])}) internal pure returns (bytes32[] memory _keyTuple) { | ||
| _keyTuple = new bytes32[](${keyTuple.length}); | ||
| ${renderList(keyTuple, (key, index) => `_keyTuple[${index}] = ${renderValueTypeToBytes32(key.name, key)};`)} | ||
| function encodeKeyTuple(${renderArguments([_typedKeyArgs])}) internal pure returns (bytes32[] memory) { | ||
| ${_keyTupleDefinition} | ||
| return _keyTuple; |
There was a problem hiding this comment.
this is the only change here correct?
alvrs
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
originally
_keyTupleDefinitionrendered a call toencodeKeyTuple, but now_keyTupleDefinitionis inlined and soencodeKeyTupleshould use it instead