Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump viem to 1.6.0 #1308

Merged
merged 13 commits into from
Aug 15, 2023
Merged

feat: bump viem to 1.6.0 #1308

merged 13 commits into from
Aug 15, 2023

Conversation

holic
Copy link
Member

@holic holic commented Aug 15, 2023

fixes #1276
fixes #1262

@changeset-bot
Copy link

changeset-bot bot commented Aug 15, 2023

🦋 Changeset detected

Latest commit: db79b4e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 27 packages
Name Type
@latticexyz/common Major
@latticexyz/block-logs-stream Major
@latticexyz/dev-tools Major
@latticexyz/network Major
@latticexyz/protocol-parser Major
@latticexyz/schema-type Major
@latticexyz/std-client Major
@latticexyz/store-indexer Major
@latticexyz/store-sync Major
create-mud Major
@latticexyz/cli Major
@latticexyz/config Major
@latticexyz/store-cache Major
@latticexyz/store Major
@latticexyz/world Major
@latticexyz/recs Major
@latticexyz/ecs-browser Major
@latticexyz/react Major
@latticexyz/gas-report Major
@latticexyz/noise Major
@latticexyz/phaserx Major
@latticexyz/services Major
@latticexyz/solecs Major
solhint-config-mud Major
solhint-plugin-mud Major
@latticexyz/std-contracts Major
@latticexyz/utils Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@holic holic marked this pull request as ready for review August 15, 2023 13:51
@holic holic requested a review from alvrs as a code owner August 15, 2023 13:51
return /already known|nonce too low/.test(String(error));
return (
error instanceof BaseError &&
error.walk((e) => e instanceof NonceTooLowError || e instanceof NonceTooHighError) != null
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for context, when is a NonceTooHighError triggered? Shouldn't it be possible to submit nonces with gaps / would viem error in that case?

Copy link
Member Author

@holic holic Aug 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

honestly not sure how to trigger this, but I assume it's in viem because it's in the geth source: https://github.com/search?q=repo%3Aethereum%2Fgo-ethereum+ErrNonceTooHigh&type=code

and seemed like a good case to re-fetch the current nonce from the chain before retrying

@holic holic merged commit b8a6158 into main Aug 15, 2023
@holic holic deleted the holic/big-viem-upgrade branch August 15, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bump viem and clean up improve createNonceManager's detection of nonce errors
2 participants