docs: barArray should be a static array #1288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If this is not a static array it will throw the error
```
➜ contracts git:(main) ✗ forge test
[⠆] Compiling...
[⠢] Compiling 5 files with 0.8.13
[⠆] Solc 0.8.13 finished in 899.89ms
Error:
Compiler run failed:
Error (9582): Member "set" not found or not visible after argument-dependent lookup in type(library MyTable).
--> src/systems/MyTableSystem.sol:23:5:
|
23 | MyTable.set(keccak256("some.key"), 45, false, fooArray, barArray);
| ^^^^^^^^^^^
```
|
holic
changed the title
holic
reviewed
Aug 12, 2023
| @@ -36,7 +36,7 @@ tables: { | |||
| ```solidity | |||
| // Setting a record | |||
| uint256[] memory fooArray = new uint256[](1); | |||
There was a problem hiding this comment.
should this likewise be
Suggested change
| uint256[] memory fooArray = new uint256[](1); | |
| uint256[1] memory fooArray; |
There was a problem hiding this comment.
No, because fooArray is a dynamic array in the table definition
alvrs
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this is not a static array it will throw the error