Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(store): remove TableId library #1279

Merged
merged 3 commits into from
Aug 11, 2023
Merged

Conversation

dk1a
Copy link
Contributor

@dk1a dk1a commented Aug 10, 2023

I think a small wrapper for abi.encodePacked isn't worth keeping an extra library file for. It's also only used for errors

@changeset-bot
Copy link

changeset-bot bot commented Aug 10, 2023

🦋 Changeset detected

Latest commit: 6a4fe89

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 27 packages
Name Type
@latticexyz/store Major
@latticexyz/cli Major
@latticexyz/network Major
@latticexyz/react Major
@latticexyz/std-client Major
@latticexyz/store-cache Major
@latticexyz/store-indexer Major
@latticexyz/store-sync Major
@latticexyz/world Major
@latticexyz/dev-tools Major
@latticexyz/ecs-browser Major
@latticexyz/block-logs-stream Major
@latticexyz/common Major
@latticexyz/config Major
create-mud Major
@latticexyz/gas-report Major
@latticexyz/noise Major
@latticexyz/phaserx Major
@latticexyz/protocol-parser Major
@latticexyz/recs Major
@latticexyz/schema-type Major
@latticexyz/services Major
@latticexyz/solecs Major
solhint-config-mud Major
solhint-plugin-mud Major
@latticexyz/std-contracts Major
@latticexyz/utils Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dk1a dk1a marked this pull request as ready for review August 11, 2023 11:56
@dk1a dk1a requested review from alvrs and holic as code owners August 11, 2023 11:56
@alvrs alvrs changed the title refactor(store): remove TableId refactor(store): remove TableId library Aug 11, 2023
@dk1a dk1a merged commit a258811 into main Aug 11, 2023
@dk1a dk1a deleted the dk1a/store-remove-tableid branch August 11, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants