Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add table tutorial #1273
docs: add table tutorial #1273
Changes from 31 commits
18d7889
d608f46
0142f22
3050d81
ee0b849
1f3bf2e
4af93aa
12083fa
c931df3
11d32eb
d12f411
9a4bc29
13a051d
b9eee88
659a298
a28e827
5dcc291
8e8218c
4228cfe
90a20cd
e3dd651
3124b6f
c9cefb8
509db86
f813f81
30f6e8f
513cbc0
b0f4156
ce4e3e9
62d047a
ceefffa
c3d9dbe
b6bd9fc
fd29f81
f32c66e
0987732
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we indent this to the same level as the
1.
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we should. However, when I do it the prettier script breaks it. :-(
When I try to indent and then commit,
prettier
"fixes" it to this:And then I get this error:
I spent enough time on it that I decided it's not worth hassling with anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the trick to get it to work is add a blank line between the opening/closing tags and the contents, like we did for the
<CollapseCode>
.Maybe there's an update to prettier that fixes these. Will look!