feat(common): remove need for tx queue in createContract
#1271
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1263
I initially thought we needed a queue to handle nonces. But once I separated the transaction simulation (to determine gas) from the nonce handling (incrementing before writing to the mem pool), I discovered we don't even need the queue anymore.
I tried this locally against our testnet and couldn't get nonce issues to appear.
We could improve this further by handling other mem pool cases and re-simulating as needed (would be nice for failures due to gas price increases).