Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common): replace TableId with tableIdToHex/hexToTableId #1258

Merged
merged 5 commits into from
Aug 9, 2023

Conversation

holic
Copy link
Member

@holic holic commented Aug 9, 2023

pulled out of #1214

@changeset-bot
Copy link

changeset-bot bot commented Aug 9, 2023

🦋 Changeset detected

Latest commit: b847672

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 27 packages
Name Type
@latticexyz/cli Major
@latticexyz/common Major
@latticexyz/dev-tools Major
@latticexyz/network Major
@latticexyz/std-client Major
@latticexyz/store-sync Major
@latticexyz/block-logs-stream Major
@latticexyz/config Major
@latticexyz/protocol-parser Major
@latticexyz/store-cache Major
@latticexyz/store-indexer Major
@latticexyz/store Major
@latticexyz/utils Major
@latticexyz/world Major
@latticexyz/ecs-browser Major
@latticexyz/react Major
@latticexyz/phaserx Major
@latticexyz/recs Major
create-mud Major
@latticexyz/gas-report Major
@latticexyz/noise Major
@latticexyz/schema-type Major
@latticexyz/services Major
@latticexyz/solecs Major
solhint-config-mud Major
solhint-plugin-mud Major
@latticexyz/std-contracts Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@holic holic marked this pull request as ready for review August 9, 2023 10:36
@holic holic requested a review from alvrs as a code owner August 9, 2023 10:36
@@ -0,0 +1,6 @@
import { TableId } from "./TableId";

/** @deprecated Use `tableIdToHex` and `hexToTableId` instead. */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this comment seems wrong; is getTableIds deprecated and if so what is the recommended alternative?

Copy link
Member Author

@holic holic Aug 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getTableIds returns TableId[] and is only used by the snap sync module in network, which expects TableId[] args so it didn't seem worth it to migrate

alvrs
alvrs previously approved these changes Aug 9, 2023
@holic holic merged commit 6c67332 into main Aug 9, 2023
@holic holic deleted the holic/deprecate-tableid branch August 9, 2023 11:45
@github-actions github-actions bot mentioned this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants