-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(common): replace TableId with tableIdToHex/hexToTableId #1258
Conversation
🦋 Changeset detectedLatest commit: b847672 The changes in this PR will be included in the next version bump. This PR includes changesets to release 27 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@@ -0,0 +1,6 @@ | |||
import { TableId } from "./TableId"; | |||
|
|||
/** @deprecated Use `tableIdToHex` and `hexToTableId` instead. */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this comment seems wrong; is getTableIds
deprecated and if so what is the recommended alternative?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getTableIds
returns TableId[]
and is only used by the snap sync module in network, which expects TableId[]
args so it didn't seem worth it to migrate
pulled out of #1214