Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Explain the root namespace #1241

Merged
merged 4 commits into from
Aug 4, 2023
Merged

docs: Explain the root namespace #1241

merged 4 commits into from
Aug 4, 2023

Conversation

qbzzt
Copy link
Contributor

@qbzzt qbzzt commented Aug 3, 2023

As requested by @ludns .

@qbzzt qbzzt requested review from alvrs and holic as code owners August 3, 2023 18:46
@changeset-bot
Copy link

changeset-bot bot commented Aug 3, 2023

⚠️ No Changeset found

Latest commit: 59650ba

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Currently, having write access only matters for systems interacting with tables: it means these systems can create and edit records within those tables.

Note that systems in the ROOT namespace are not subject to access control.
They can bypass any hooks and write directly to any table in the `World`.
Copy link
Contributor

@dk1a dk1a Aug 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dunno if it's worth clarifying - altough bypassing hooks is possible, it isn't supposed to happen and there're no tools for it. You'd have to manually make a version of StoreCore.setField without the hook calls and rewrite any table libs accordingly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a security matter, so I think we should be as clear as possible about potential vulnerabilities.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah ofc, I meant clarifying that you shouldn't expect this to normally happen, it's just a security nuance

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I clarified it would be bypassing security.

@qbzzt qbzzt merged commit 081f57b into main Aug 4, 2023
@qbzzt qbzzt deleted the 230803-explain-root-ns branch August 4, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants