Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(store): update tightcoder codegen, optimize TightCoder library #1210

Merged
merged 13 commits into from
Aug 6, 2023
Merged

refactor(store): update tightcoder codegen, optimize TightCoder library #1210

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
3fd5be6
add isLeftAligned, shiftLeftBits common methods
dk1a Jul 31, 2023
5422dc6
refactor TightCoder codegen
dk1a Jul 31, 2023
908bf9d
cleanup
dk1a Jul 31, 2023
9750240
gas-report
dk1a Jul 31, 2023
0f27a0c
remove ejs files
dk1a Jul 31, 2023
a7dead2
manually allocate memory in encode, update comments
dk1a Jul 31, 2023
ad77b29
optimize decode
dk1a Jul 31, 2023
8a27d2d
Create witty-jokes-serve.md
dk1a Jul 31, 2023
c4ad0af
update codegen
dk1a Jul 31, 2023
9559957
Update .changeset/witty-jokes-serve.md
dk1a Aug 3, 2023
666e2d0
rename shiftLeftBits to getLeftPaddingBits
dk1a Aug 3, 2023
b2101cf
Merge branch 'main' into dk1a/tightcoder2
dk1a Aug 3, 2023
f09aed7
rename generate-tightcoder script to build:tightcoder
dk1a Aug 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .changeset/witty-jokes-serve.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
"@latticexyz/common": patch
"@latticexyz/store": patch
"@latticexyz/world": patch
---

Refactor tightcoder to use typescript functions instead of ejs
Optimize `TightCoder` library
Add `isLeftAligned` and `shiftLeftBits` common codegen helpers
dk1a marked this conversation as resolved.
Show resolved Hide resolved
12 changes: 12 additions & 0 deletions packages/common/src/codegen/render-solidity/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,18 @@ export function renderValueTypeToBytes32(name: string, { typeUnwrap, internalTyp
}
}

export function isLeftAligned(field: Pick<RenderType, "internalTypeId">): boolean {
return field.internalTypeId.match(/^bytes\d{1,2}$/) !== null;
}

export function shiftLeftBits(field: Pick<RenderType, "internalTypeId" | "staticByteLength">): number {
dk1a marked this conversation as resolved.
Show resolved Hide resolved
if (isLeftAligned(field)) {
return 0;
} else {
return 256 - field.staticByteLength * 8;
}
}

function internalRenderList<T>(
lineTerminator: string,
list: T[],
Expand Down
Loading