Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: combine name and namespace to resource selector in World methods #1208

Merged
merged 16 commits into from
Aug 17, 2023
Merged

refactor: combine name and namespace to resource selector in World methods #1208

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
c873e75
wip: combine name and namespace to resource selector in function sign…
alvrs Jul 19, 2023
e743b02
continue refactoring namespace+name to resource selector
alvrs Aug 9, 2023
89cdc13
more refactor to change function interfaces
alvrs Aug 11, 2023
66c246a
fix tests
alvrs Aug 11, 2023
ad4e6d7
build
alvrs Aug 16, 2023
64f4a1a
fix deploy
alvrs Aug 16, 2023
c94419d
fix e2e
alvrs Aug 16, 2023
57beee8
fix example PostDeploy
alvrs Aug 16, 2023
f4ef35a
remove stale interface
alvrs Aug 16, 2023
64c5617
Create grumpy-geckos-raise.md
alvrs Aug 16, 2023
6718ac6
remove stale file
alvrs Aug 16, 2023
fd059bd
prettier
alvrs Aug 16, 2023
2368063
Update .changeset/grumpy-geckos-raise.md
holic Aug 17, 2023
8264c11
Merge remote-tracking branch 'origin/main' into alvrs/resource-selector
holic Aug 17, 2023
26e9b47
Apply suggestions from code review
holic Aug 17, 2023
28a0268
Merge remote-tracking branch 'origin/main' into alvrs/resource-selector
holic Aug 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .changeset/grumpy-geckos-raise.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
---
"@latticexyz/cli": major
"@latticexyz/common": patch
holic marked this conversation as resolved.
Show resolved Hide resolved
"@latticexyz/world": major
---

- All `World` function selectors that previously had `bytes16 namespace, bytes16 name` arguments now use `bytes32 resourceSelector` instead.
This includes `setRecord`, `setField`, `pushToField`, `popFromField`, `updateInField`, `deleteRecord`, `call`, `grantAccess`, `revokeAccess`, `registerTable`,
`registerStoreHook`, `registerSystemHook`, `registerFunctionSelector`, `registerSystem` and `registerRootFunctionSelector`.
This changes aligns the `World` function selectors with the `Store` function selectors, reduces clutter, reduces gas cost and reduces the `World`'s contract size.
holic marked this conversation as resolved.
Show resolved Hide resolved

- The `World`'s `registerHook` function is removed. Use `registerStoreHook` or `registerSystemHook` instead.

- The `deploy` script is updated to integrate the World interface changes
Loading