Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pin node to 18.16.1 #1200

Merged
merged 1 commit into from
Jul 27, 2023
Merged

chore: pin node to 18.16.1 #1200

merged 1 commit into from
Jul 27, 2023

Conversation

holic
Copy link
Member

@holic holic commented Jul 27, 2023

18.17.0 is breaking our end-to-end tests with some internal URL changes

Node.js v18.17.0 comes with the latest version of the URL parser, Ada. This update brings significant performance improvements to URL parsing, including enhancements to the url.domainToASCII and url.domainToUnicode functions in node:url.

Ada 2.0 has been integrated into the Node.js codebase, ensuring that all parts of the application can benefit from the
improved performance. Additionally, Ada 2.0 features a significant performance boost over its predecessor, Ada 1.0.4,
while also eliminating the need for the ICU requirement for URL hostname parsing.

image

18.17.0 is breaking our end-to-end tests with some internal URL changes
@changeset-bot
Copy link

changeset-bot bot commented Jul 27, 2023

⚠️ No Changeset found

Latest commit: e4fc550

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@holic
Copy link
Member Author

holic commented Jul 27, 2023

I assume we can get back on the latest v18 changes once Playwright updates?

@holic holic marked this pull request as ready for review July 27, 2023 16:31
@holic holic requested a review from alvrs as a code owner July 27, 2023 16:31
@holic holic mentioned this pull request Jul 27, 2023
@alvrs
Copy link
Member

alvrs commented Jul 27, 2023

I assume we can get back on the latest v18 changes once Playwright updates?

Or vite? looks like the function that causes the type error is in vite? (should we open an issue on their end?)

@holic holic merged commit 0d1a7e0 into main Jul 27, 2023
@holic holic deleted the holic/pin-node-version branch July 27, 2023 16:39
@holic
Copy link
Member Author

holic commented Jul 27, 2023

Or vite? looks like the function that causes the type error is in vite? (should we open an issue on their end?)

I checked vite CI and looks like their node 18 tests ran against 18.17.0 just fine so I'm not sure it's there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants