Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(store-sync): sync to RECS #1197

Merged
merged 13 commits into from
Jul 31, 2023
Merged

feat(store-sync): sync to RECS #1197

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
a9032fc
feat(store-sync): add syncToRecs strategy and utils
holic Jul 27, 2023
3e359ef
remove done TODO
holic Jul 27, 2023
75552db
remove other todo
holic Jul 27, 2023
b6cb5e4
Create great-cooks-dream.md
holic Jul 27, 2023
797b878
Update great-cooks-dream.md
holic Jul 27, 2023
9c6623f
Merge remote-tracking branch 'origin/main' into holic/store-sync-recs
holic Jul 27, 2023
9f94d84
rework waitForTransaction
holic Jul 27, 2023
6ba5a5f
refactor a bit
holic Jul 27, 2023
509380d
move types around
holic Jul 31, 2023
b85e56c
only update sync progress every 1000 records hydrated
holic Jul 31, 2023
2e7da90
update roughly once per percent
holic Jul 31, 2023
84c54cd
move off of behavior subject
holic Jul 31, 2023
543334c
Merge remote-tracking branch 'origin/main' into holic/store-sync-recs
holic Jul 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/store-sync/src/recs/syncToRecs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ export async function syncToRecs<
const componentList = Object.values(components);

const numRecords = initialState.tables.reduce((sum, table) => sum + table.records.length, 0);
const recordsPerSyncProgressUpdate = Math.floor(numRecords / 100);
let recordsProcessed = 0;

for (const table of initialState.tables) {
Expand All @@ -115,7 +116,7 @@ export async function syncToRecs<
setComponent(component, entity, record.value as ComponentValue);

recordsProcessed++;
if (recordsProcessed % 1000 === 0) {
if (recordsProcessed % recordsPerSyncProgressUpdate === 0) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

setComponent(components.SyncProgress, singletonEntity, {
step: SyncStep.SNAPSHOT,
message: `Hydrating from snapshot to block ${initialState.blockNumber}`,
Expand Down