Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol-parser): properly decode empty records #1177

Merged
merged 3 commits into from
Jul 19, 2023

Conversation

holic
Copy link
Member

@holic holic commented Jul 18, 2023

Pulled out of #1113

@changeset-bot
Copy link

changeset-bot bot commented Jul 18, 2023

🦋 Changeset detected

Latest commit: 7910c3e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 26 packages
Name Type
@latticexyz/protocol-parser Patch
@latticexyz/store-sync Patch
@latticexyz/block-logs-stream Patch
@latticexyz/cli Patch
@latticexyz/common Patch
@latticexyz/config Patch
create-mud Patch
@latticexyz/dev-tools Patch
@latticexyz/ecs-browser Patch
@latticexyz/gas-report Patch
@latticexyz/network Patch
@latticexyz/noise Patch
@latticexyz/phaserx Patch
@latticexyz/react Patch
@latticexyz/recs Patch
@latticexyz/schema-type Patch
@latticexyz/services Patch
@latticexyz/solecs Patch
solhint-config-mud Patch
solhint-plugin-mud Patch
@latticexyz/std-client Patch
@latticexyz/std-contracts Patch
@latticexyz/store-cache Patch
@latticexyz/store Patch
@latticexyz/utils Patch
@latticexyz/world Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@holic holic marked this pull request as ready for review July 18, 2023 16:08
@holic holic requested a review from alvrs as a code owner July 18, 2023 16:08
@alvrs
Copy link
Member

alvrs commented Jul 18, 2023

@alvrs
Copy link
Member

alvrs commented Jul 18, 2023

oh i guess it's because of #1175 ?

@holic
Copy link
Member Author

holic commented Jul 19, 2023

oh yep! there's a test in here that should have been with #1175

@holic holic merged commit 4bb7e8c into main Jul 19, 2023
@holic holic deleted the holic/fix-decode-empty-record branch July 19, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants