feat(common): new utils, truncate table ID parts #1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f061394 The changes in this PR will be included in the next version bump. This PR includes changesets to release 26 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
holic
changed the title
holic
changed the title
alvrs
previously approved these changes
Jul 19, 2023
packages/common/src/TableId.test.ts
Outdated
Comment on lines
14
to
25
| expect(tableId.toHex()).toMatchInlineSnapshot( | ||
| '"0x41566572794c6f6e674e616d657370616e616d65000000000000000000000000"' | ||
| ); | ||
| expect(TableId.fromHex(tableId.toHex()).namespace).toMatchInlineSnapshot('"AVeryLongNamespa"'); | ||
| }); | ||
|
|
||
| it("throws when converting names >16 bytes", () => { | ||
| const tableId = new TableId("namespace", "AnUnnecessarilyLongName"); | ||
| expect(() => tableId.toHex()).toThrow("Size cannot exceed 16 bytes. Given size: 23 bytes."); | ||
| expect(tableId.toHex()).toMatchInlineSnapshot( | ||
| '"0x6e616d65737061636500000000000000416e556e6e65636573736172696c794c"' | ||
| ); | ||
| expect(TableId.fromHex(tableId.toHex()).name).toMatchInlineSnapshot('"AnUnnecessarilyL"'); |
There was a problem hiding this comment.
we should update the titles of both of these tests to reflect the new behavior
Co-authored-by: alvarius <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled out of #1113