Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gas examples: storeAddress via storage #1158

Closed
wants to merge 17 commits into from

Conversation

dk1a
Copy link
Contributor

@dk1a dk1a commented Jul 14, 2023

#1061 (review) I should've started with this

This is comparing storeAddress as a method (optimized to not pass in msgSender for a better comparison)
to storeAddress as a storage variable

storage seems almost universally better. We pay ~1000-1500 up front, but get ~500-1000 less gas on each subsequent table interaction. So as long as you read/write more than like twice, it evens out and then keeps getting cheaper

the code is a mess, this is just a gas comparison. I'll continue the PR in #1061

@changeset-bot
Copy link

changeset-bot bot commented Jul 14, 2023

⚠️ No Changeset found

Latest commit: b7a8e34

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dk1a
Copy link
Contributor Author

dk1a commented Jul 14, 2023

I should note that the method version is not fully optimized, whereas the storage version doesn't need as much optimization, so the comparison is still possibly unfair, this may be worth exploring further
tried more optimizations, gas margins changed but the idea remains the same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant