Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(store): clean up Utils, add tests #1149

Merged
merged 2 commits into from
Jul 13, 2023
Merged

test(store): clean up Utils, add tests #1149

merged 2 commits into from
Jul 13, 2023

Conversation

dk1a
Copy link
Contributor

@dk1a dk1a commented Jul 12, 2023 •
edited
Loading

addresses part of #1133
didn't see a need for gas metering/optimization here, but did some clean up and tests

@changeset-bot
Copy link

changeset-bot bot commented Jul 12, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: a1d2287

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dk1a dk1a force-pushed the dk1a/store-utils branch from 93a331d to 0ba7116 Compare July 12, 2023 12:42
@dk1a dk1a marked this pull request as ready for review July 12, 2023 16:23
@dk1a dk1a requested review from alvrs and holic as code owners July 12, 2023 16:23
@dk1a dk1a force-pushed the dk1a/store-utils branch from 48bde4e to a1d2287 Compare July 12, 2023 16:45
@dk1a dk1a merged commit 168b494 into main Jul 13, 2023
@dk1a dk1a deleted the dk1a/store-utils branch July 13, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holic holic holic approved these changes

@alvrs alvrs Awaiting requested review from alvrs alvrs is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dk1a @holic