-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gas-report): create package, move relevant files to it #1147
Conversation
🦋 Changeset detectedLatest commit: 8a5f968 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
thoughts on refactoring gas report TS to be more of a output parser than a test runner? |
if you mean to separate it into a parser and a runner that seems nice if not particularly important; |
@@ -1,4 +1,4 @@ | |||
lockfileVersion: '6.1' | |||
lockfileVersion: '6.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
which version of pnpm are you currently on?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8.6.7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good! would you mind adding a simple example for how to use the gas report to the readme and adding a changeset?
I'm assuming we don't want to strictly follow semver for now and avoid |
This reverts commit c9f0d4b.
(tried fiddling with e2e but then figured it shouldn't be part of this PR and merged as it was when @holic approved it) |
fixes #667