Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove devEmit when sending events from SyncWorker #1109

Merged
merged 4 commits into from
Jul 6, 2023

Conversation

Kooshaba
Copy link
Contributor

@Kooshaba Kooshaba commented Jul 5, 2023

big hack that just removes devEmit when we are sending events from the SyncWorker

lmk if this is too hacky and you have a less terrible way of doing it

@Kooshaba Kooshaba requested review from alvrs and holic as code owners July 5, 2023 20:56
@changeset-bot
Copy link

changeset-bot bot commented Jul 5, 2023

🦋 Changeset detected

Latest commit: 62ab06a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@latticexyz/network Patch
@latticexyz/dev-tools Patch
@latticexyz/std-client Patch
@latticexyz/ecs-browser Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

holic
holic previously approved these changes Jul 6, 2023
Copy link
Member

@holic holic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@holic holic merged commit e019c77 into main Jul 6, 2023
@holic holic deleted the kooshaba/sync-worker-hack branch July 6, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants