Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(schema-type): add schemaTypeToPrimitiveType #1063

Merged
merged 2 commits into from
Jun 23, 2023
Merged

feat(schema-type): add schemaTypeToPrimitiveType #1063

merged 2 commits into from
Jun 23, 2023

Conversation

alvrs
Copy link
Member

@alvrs alvrs commented Jun 21, 2023

No description provided.

@alvrs alvrs requested a review from holic as a code owner June 21, 2023 17:39
@changeset-bot
Copy link

changeset-bot bot commented Jun 21, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: ce9f69e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@alvrs
Copy link
Member Author

alvrs commented Jun 21, 2023 •
edited
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@alvrs alvrs mentioned this pull request Jun 21, 2023
Merged
holic
holic previously approved these changes Jun 21, 2023
View reviewed changes
packages/schema-type/src/typescript/schemaAbiTypeToPrimitiveType.ts
? string
: never;

export type SchemaAbiTypeToPrimitiveType<T extends SchemaAbiType> = LiteralToBroad<
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worth adding this to the static and dynamic schema type to primitive type helpers?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@alvrs alvrs merged commit 6f8c2c4 into main Jun 23, 2023
@alvrs alvrs deleted the alvrs/schema-type-to-primitive branch June 23, 2023 11:48
@alvrs alvrs mentioned this pull request Jun 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holic holic holic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alvrs @holic