Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: clean rebuild in build action, use turbo cache in all other actions #1045

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

alvrs
Copy link
Member

@alvrs alvrs commented Jun 16, 2023

  • In build: clean before build #1027 we added a clean step before the build step. The clean step removes build artifacts, so afterwards a full rebuild is necessary. This caused an issue if the turbo cache was hit and the rebuild was skipped, eg https://github.com/latticexyz/mud/actions/runs/5293787981/jobs/9582365505?pr=1011
  • This PR changes pulls out the build step from the the Setup composite action and instead creates a new Build composite action that uses the turbo cache and does not clean the artifacts
  • This new Build composite action is used in all actions, except the Build and validate artifacts action, which first cleans the artifacts and then performs a full rebuild without the turbo cache.

@alvrs alvrs requested a review from holic as a code owner June 16, 2023 21:00
@changeset-bot
Copy link

changeset-bot bot commented Jun 16, 2023

⚠️ No Changeset found

Latest commit: 9eb4438

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@alvrs
Copy link
Member Author

alvrs commented Jun 16, 2023

self-approving to unblock #1011

@alvrs alvrs merged commit 0c9640d into main Jun 16, 2023
@alvrs alvrs deleted the alvrs/ci-build branch June 16, 2023 21:09
@alvrs alvrs mentioned this pull request Jun 16, 2023
holic added a commit that referenced this pull request Jun 17, 2023
@holic holic mentioned this pull request Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant