Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove system name from function signatures/selectors #1980

Closed
holic opened this issue Nov 30, 2023 · 0 comments · Fixed by #2160
Closed

remove system name from function signatures/selectors #1980

holic opened this issue Nov 30, 2023 · 0 comments · Fixed by #2160

Comments

@holic
Copy link
Member

holic commented Nov 30, 2023

Instead of {namespace}_{systemName}_{functionName} for world function selectors, just use {namespace}_{functionName}

This has a bunch of benefits:

  • more closely matches root systems where the world function doesn't indicate which system the function is in
  • more closely matches how namespaced tables ({namespace}_{tableName}) are accessed in downstream tooling
  • more ergonomic
  • removes the need for us to add validation for system names (to ensure they don't have underscores)
@holic holic added this to the v2 MUD stable milestone Jan 12, 2024
@holic holic changed the title consider registering function selectors as {namespace}_{functionName} remove system name from function selectors Jan 17, 2024
@holic holic changed the title remove system name from function selectors remove system name from function signatures/selectors Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant