refactor: signature is string

latticexyz · Mar 7, 2024 · b5549d0 · b5549d0
1 parent 9137a92
commit b5549d0
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/packages/world/src/modules/init/implementations/WorldRegistrationSystem.sol b/packages/world/src/modules/init/implementations/WorldRegistrationSystem.sol
@@ -202,8 +202,8 @@ contract WorldRegistrationSystem is System, IWorldErrors, LimitedCallContext {
 
     // Compute global function selector
     string memory namespaceString = WorldResourceIdLib.toTrimmedString(systemId.getNamespace());
-    bytes memory worldFunctionSignature = abi.encodePacked(namespaceString, "__", systemFunctionSignature);
-    worldFunctionSelector = bytes4(keccak256(worldFunctionSignature));
+    string memory worldFunctionSignature = string.concat(namespaceString, "__", systemFunctionSignature);
+    worldFunctionSelector = bytes4(keccak256(bytes(worldFunctionSignature)));
 
     // Require the function selector to be globally unique
     ResourceId existingSystemId = FunctionSelectors._getSystemId(worldFunctionSelector);
@@ -216,7 +216,7 @@ contract WorldRegistrationSystem is System, IWorldErrors, LimitedCallContext {
 
     // Register the function signatures for offchain use
     FunctionSignatures._set(systemFunctionSelector, systemFunctionSignature);
-    FunctionSignatures._set(worldFunctionSelector, string(worldFunctionSignature));
+    FunctionSignatures._set(worldFunctionSelector, worldFunctionSignature);
   }
 
   /**