fix(protocol-parser): only append packed counter if there is dynamic …

…data (#1097)
latticexyz · Jul 3, 2023 · 8619d15 · 8619d15
1 parent b9319d1
commit 8619d15
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/packages/protocol-parser/src/encodeRecord.test.ts b/packages/protocol-parser/src/encodeRecord.test.ts
@@ -9,4 +9,10 @@ describe("encodeRecord", () => {
       "0x0000000100000000000000000000000000000002000000000000130000000008000000000b0000000000000000000000000000000000000300000004736f6d6520737472696e67"
     );
   });
+
+  it("should not include the packed dynamic lengths if there are no dynamic fields", () => {
+    const schema = { staticFields: ["uint32", "uint128"], dynamicFields: [] } as const;
+    const hex = encodeRecord(schema, [1, 2n]);
+    expect(hex).toBe("0x0000000100000000000000000000000000000002");
+  });
 });
diff --git a/packages/protocol-parser/src/encodeRecord.ts b/packages/protocol-parser/src/encodeRecord.ts
@@ -11,6 +11,8 @@ export function encodeRecord(schema: Schema, values: readonly (StaticPrimitiveTy
     .map((value, i) => encodeField(schema.staticFields[i], value).replace(/^0x/, ""))
     .join("");
 
+  if (schema.dynamicFields.length === 0) return `0x${staticData}`;
+
   const dynamicDataItems = dynamicValues.map((value, i) =>
     encodeField(schema.dynamicFields[i], value).replace(/^0x/, "")
   );