review feedback

.eslintrc

@@ -14,6 +14,7 @@
       {
         "extendDefaults": true,
         "types": {
+          // don't throw an error for the empty object type ({})
           "{}": false,
         },
       },

packages/store/ts/config/v2/store.test.ts

@@ -37,6 +37,7 @@ describe("resolveStoreConfig", () => {
       enums: {},
       namespace: "",
     } as const;
+
     attest<typeof expected>(config);
   });
 
@@ -74,6 +75,7 @@ describe("resolveStoreConfig", () => {
       enums: {},
       namespace: "",
     } as const;
+
     attest<typeof expected>(config);
   });
 
@@ -119,6 +121,7 @@ describe("resolveStoreConfig", () => {
       enums: {},
       namespace: "",
     } as const;
+
     attest<typeof expected>(config);
   });
 
@@ -164,6 +167,7 @@ describe("resolveStoreConfig", () => {
       enums: {},
       namespace: "",
     } as const;
+
     attest<typeof expected>(config);
   });
 
@@ -247,6 +251,7 @@ describe("resolveStoreConfig", () => {
       enums: {},
       namespace: "",
     } as const;
+
     attest<typeof expected>(config);
   });
 
@@ -300,6 +305,7 @@ describe("resolveStoreConfig", () => {
       enums: {},
       namespace: "",
     } as const;
+
     attest<typeof expected>(config);
   }),
     it("it should return the full config given a full config with two primaryKey", () => {
@@ -351,6 +357,7 @@ describe("resolveStoreConfig", () => {
         enums: {},
         namespace: "",
       } as const;
+
       attest<typeof expected>(config);
     });
 
@@ -440,6 +447,7 @@ describe("resolveStoreConfig", () => {
       enums: {},
       namespace: "",
     } as const;
+
     attest<typeof expected>(config);
   });
 
@@ -530,6 +538,7 @@ describe("resolveStoreConfig", () => {
       enums: {},
       namespace: "",
     } as const;
+
     attest<typeof expected>(config);
   });
 
@@ -637,11 +646,13 @@ describe("resolveStoreConfig", () => {
       },
       namespace: "",
     } as const;
+
     attest<typeof expected>(config);
   });
 
   it("should use the root namespace as default namespace", () => {
     const config = resolveStoreConfig({ tables: { Example: {} } });
+
     attest<"">(config.namespace);
   });
 });

packages/store/ts/config/v2/store.ts

@@ -50,7 +50,7 @@ export type validateStoreConfig<input> = {
         : input[key];
 };
 
-export type resolveEnums<enums> = { [key in keyof enums]: Readonly<enums[key]> };
+export type resolveEnums<enums> = { readonly [key in keyof enums]: Readonly<enums[key]> };
 
 export type resolveStoreConfig<input> = evaluate<{
   readonly tables: "tables" extends keyof input ? resolveStoreTablesConfig<input["tables"], extendedScope<input>> : {};

packages/store/ts/config/v2/table.test.ts

@@ -13,6 +13,7 @@ describe("validateKeys", () => {
 
   it("should return a tuple of valid keys with an extended scope", () => {
     const scope = extendScope(AbiTypeScope, { static: "address", dynamic: "string" });
+
     attest<
       ["static", "customStatic"],
       validateKeys<
@@ -34,6 +35,7 @@ describe("validateKeys", () => {
 
   it("should return a tuple of valid keys with an extended scope", () => {
     const scope = extendScope(AbiTypeScope, { static: "address", dynamic: "string" });
+
     attest<
       ["static", "customStatic"],
       validateKeys<
@@ -50,6 +52,7 @@ describe("validateKeys", () => {
 describe("resolveTableShorthand", () => {
   it("should expand a single ABI type into a key/value schema", () => {
     const table = resolveTableShorthand("address");
+
     attest<{
       schema: {
         key: "bytes32";
@@ -62,6 +65,7 @@ describe("resolveTableShorthand", () => {
   it("should expand a single custom into a key/value schema", () => {
     const scope = extendScope(AbiTypeScope, { CustomType: "uint256" });
     const table = resolveTableShorthand("CustomType", scope);
+
     attest<{
       schema: {
         key: "bytes32";
@@ -88,6 +92,7 @@ describe("resolveTableShorthand", () => {
 
   it("should use `key` as single key if it has a static ABI type", () => {
     const table = resolveTableShorthand({ key: "address", name: "string", age: "uint256" });
+
     attest<{
       schema: {
         key: "address";
@@ -124,6 +129,7 @@ describe("resolveTableShorthand", () => {
   it("should use `key` as single key if it has a static custom type", () => {
     const scope = extendScope(AbiTypeScope, { CustomType: "uint256" });
     const table = resolveTableShorthand({ key: "CustomType", name: "string", age: "uint256" }, scope);
+
     attest<{
       schema: { key: "CustomType"; name: "string"; age: "uint256" };
       primaryKey: ["key"];
@@ -134,6 +140,7 @@ describe("resolveTableShorthand", () => {
 
   it("should throw an error if `key` is not a custom static type", () => {
     const scope = extendScope(AbiTypeScope, { CustomType: "bytes" });
+
     // @ts-expect-error "Error: Provide a `key` field with static ABI type or a full config with explicit primaryKey override."
     attest(resolveTableShorthand({ key: "CustomType", name: "string", age: "uint256" }, scope)).type.errors(
       `Provide a \`key\` field with static ABI type or a full config with explicit primaryKey override.`,
@@ -169,6 +176,7 @@ describe("resolveTableConfig", () => {
       },
       primaryKey: ["key"],
     } as const;
+
     attest<typeof expected>(table);
   });
 
@@ -200,6 +208,7 @@ describe("resolveTableConfig", () => {
       },
       primaryKey: ["key"],
     } as const;
+
     attest<typeof expected>(table);
   });
 
@@ -238,6 +247,7 @@ describe("resolveTableConfig", () => {
       },
       primaryKey: ["key"],
     } as const;
+
     attest<typeof expected>(table);
   });
 
@@ -277,6 +287,7 @@ describe("resolveTableConfig", () => {
       },
       primaryKey: ["key"],
     } as const;
+
     attest<typeof expected>(table);
   });
 
@@ -329,6 +340,7 @@ describe("resolveTableConfig", () => {
       },
       primaryKey: ["age"],
     } as const;
+
     attest<typeof expected>(table);
   });
 
@@ -352,6 +364,7 @@ describe("resolveTableConfig", () => {
       },
       primaryKey: ["age", "key"],
     } as const;
+
     attest<typeof expected>(table);
   });
 
@@ -391,6 +404,7 @@ describe("resolveTableConfig", () => {
       },
       primaryKey: ["key"],
     } as const;
+
     attest<typeof expected>(table);
   });
 
@@ -430,6 +444,7 @@ describe("resolveTableConfig", () => {
       },
       primaryKey: ["key"],
     } as const;
+
     attest<typeof expected>(table);
   });
 

packages/world/ts/config/v2/world.test.ts

@@ -253,6 +253,7 @@ describe("resolveWorldConfig", () => {
         namespace: "",
         namespaces: {},
       } as const;
+
       attest<typeof config>(expected);
     });
 
@@ -470,6 +471,7 @@ describe("resolveWorldConfig", () => {
         namespace: "",
         namespaces: {},
       } as const;
+
       attest<typeof expected>(config);
     });
 
@@ -669,6 +671,7 @@ describe("resolveWorldConfig", () => {
         namespace: "",
         namespaces: {},
       } as const;
+
       attest<typeof expected>(config);
     });
 
@@ -760,6 +763,7 @@ describe("resolveWorldConfig", () => {
         namespace: "",
         namespaces: {},
       } as const;
+
       attest<typeof expected>(config);
     });
 
@@ -868,11 +872,13 @@ describe("resolveWorldConfig", () => {
         namespace: "",
         namespaces: {},
       } as const;
+
       attest<typeof expected>(config);
     });
 
     it("should use the root namespace as default namespace", () => {
       const config = resolveWorldConfig({ tables: { Example: {} } });
+
       attest<"">(config.namespace);
     });
   });

packages/world/ts/config/v2/world.ts

@@ -20,7 +20,7 @@ export type WorldConfigInput<userTypes extends UserTypes = UserTypes, enums exte
 
 export type NamespacesInput = { [key: string]: NamespaceInput };
 
-export type NamespaceInput = Omit<StoreConfigInput, "userTypes" | "enums">;
+export type NamespaceInput = Pick<StoreConfigInput, "tables">;
 
 export type validateNamespaces<input, scope extends AbiTypeScope = AbiTypeScope> = {
   [namespace in keyof input]: {

templates/phaser/.vscode/settings.json

@@ -1 +1,3 @@
-{}
+{
+  "typescript.tsdk": "node_modules/typescript/lib"
+}

templates/react-ecs/.vscode/settings.json

@@ -1 +1,3 @@
-{}
+{
+  "typescript.tsdk": "node_modules/typescript/lib"
+}

templates/react/.vscode/settings.json

@@ -1 +1,3 @@
-{}
+{
+  "typescript.tsdk": "node_modules/typescript/lib"
+}

templates/threejs/.vscode/settings.json

@@ -1 +1,3 @@
-{}
+{
+  "typescript.tsdk": "node_modules/typescript/lib"
+}

templates/vanilla/.vscode/settings.json

@@ -1 +1,3 @@
-{}
+{
+  "typescript.tsdk": "node_modules/typescript/lib"
+}