refactor(common): cleanup some inferred types, add TS benchmark (#2956)

Co-authored-by: Kevin Ingersoll <[email protected]>

.gitignore

@@ -22,3 +22,4 @@ test-data/world-logs-bulk-*.json
 test-data/world-logs-query.json
 
 .attest
+.tstrace

package.json

@@ -37,6 +37,7 @@
     "package.json": "pnpm sort-package-json"
   },
   "devDependencies": {
+    "@ark/attest": "0.9.2",
     "@changesets/cli": "^2.26.1",
     "@types/node": "^18.15.11",
     "@typescript-eslint/eslint-plugin": "7.1.1",
@@ -51,6 +52,7 @@
     "prettier": "3.2.5",
     "prettier-plugin-solidity": "1.3.1",
     "rimraf": "^3.0.2",
+    "tsx": "4.16.2",
     "turbo": "^1.9.3",
     "typescript": "5.4.2"
   },

packages/common/src/getContract.ts

@@ -79,16 +79,16 @@ export function getContract<
   TPublicClient,
   TWalletClient
 >): GetContractReturnType<TAbi, { public: TPublicClient; wallet: TWalletClient }, TAddress> {
-  const contract = viem_getContract({
+  const contract: GetContractReturnType<TAbi, { public: TPublicClient; wallet: TWalletClient }, TAddress> & {
+    write: unknown;
+  } = viem_getContract({
     abi,
     address,
     client: {
       public: publicClient,
       wallet: walletClient,
     },
-  }) as unknown as GetContractReturnType<TAbi, { public: TPublicClient; wallet: TWalletClient }, TAddress> & {
-    write: unknown;
-  };
+  }) as never;
 
   if (contract.write) {
     // Replace write calls with our own. Implemented ~the same as viem, but adds better handling of nonces (via queue + retries).
@@ -104,21 +104,21 @@ export function getContract<
             ]
           ) => {
             const { args, options } = getFunctionParameters(parameters);
-            const request = {
+            const request: WriteContractParameters<
+              TAbi,
+              ContractFunctionName<TAbi, "nonpayable" | "payable">,
+              ContractFunctionArgs<TAbi, "nonpayable" | "payable">,
+              TChain,
+              TAccount
+            > = {
               abi,
               address,
               functionName,
               args,
               ...options,
               onWrite,
-            } as unknown as WriteContractParameters<
-              TAbi,
-              ContractFunctionName<TAbi, "nonpayable" | "payable">,
-              ContractFunctionArgs<TAbi, "nonpayable" | "payable">,
-              TChain,
-              TAccount
-            >;
-            const result = writeContract(walletClient, request, { publicClient });
+            } as never;
+            const result = writeContract(walletClient, request, { publicClient }) as never;
 
             const id = `${walletClient.chain.id}:${walletClient.account.address}:${nextWriteId++}`;
             onWrite?.({
@@ -134,5 +134,5 @@ export function getContract<
     );
   }
 
-  return contract as unknown as GetContractReturnType<TAbi, { public: TPublicClient; wallet: TWalletClient }, TAddress>;
+  return contract;
 }