refactor(store,world,world-modules): code suggestions [N-08] (#2140)

latticexyz · Jan 18, 2024 · 37c228c · 37c228c
1 parent 7b28d32
commit 37c228c
Show file tree

Hide file tree

Showing 58 changed files with 506 additions and 458 deletions.
diff --git a/.changeset/happy-ants-lay.md b/.changeset/happy-ants-lay.md
@@ -0,0 +1,6 @@
+---
+"@latticexyz/store": patch
+"@latticexyz/world": patch
+---
+
+Refactored various files to specify integers in a hex base instead of decimals.
diff --git a/.changeset/little-cherries-rule.md b/.changeset/little-cherries-rule.md
@@ -0,0 +1,5 @@
+---
+"@latticexyz/world": patch
+---
+
+Made the `coreModule` variable in `WorldFactory` immutable.
diff --git a/.changeset/little-cobras-yell.md b/.changeset/little-cobras-yell.md
@@ -0,0 +1,5 @@
+---
+"@latticexyz/world": patch
+---
+
+Removed the unnecessary `extcodesize` check from the `Create2` library.
diff --git a/.changeset/modern-impalas-stare.md b/.changeset/modern-impalas-stare.md
@@ -0,0 +1,7 @@
+---
+"@latticexyz/world-modules": patch
+"@latticexyz/store": patch
+"@latticexyz/world": patch
+---
+
+Refactored `ResourceId` to use a global Solidity `using` statement.
diff --git a/.changeset/nasty-owls-sneeze.md b/.changeset/nasty-owls-sneeze.md
@@ -0,0 +1,7 @@
+---
+"@latticexyz/world-modules": patch
+"@latticexyz/store": patch
+"@latticexyz/world": patch
+---
+
+Refactored EIP165 usages to use the built-in interfaceId property instead of pre-defined constants.
diff --git a/.changeset/soft-panthers-develop.md b/.changeset/soft-panthers-develop.md
@@ -0,0 +1,7 @@
+---
+"@latticexyz/world-modules": patch
+"@latticexyz/store": patch
+"@latticexyz/world": patch
+---
+
+Refactored various Solidity files to not explicitly initialise variables to zero.
diff --git a/.changeset/spotty-balloons-itch.md b/.changeset/spotty-balloons-itch.md
@@ -0,0 +1,5 @@
+---
+"@latticexyz/store": patch
+---
+
+Refactored some Store functions to use a right bit mask instead of left.
diff --git a/.changeset/thin-days-sparkle.md b/.changeset/thin-days-sparkle.md
@@ -0,0 +1,5 @@
+---
+"@latticexyz/store": patch
+---
+
+Simplified a check in `Slice.getSubslice`.
diff --git a/.changeset/three-llamas-sin.md b/.changeset/three-llamas-sin.md
@@ -0,0 +1,5 @@
+---
+"@latticexyz/world": patch
+---
+
+Refactored `WorldContext` to get the world address from `WorldContextConsumerLib` instead of `StoreSwitch`.
diff --git a/.changeset/weak-otters-turn.md b/.changeset/weak-otters-turn.md
@@ -0,0 +1,5 @@
+---
+"@latticexyz/store": patch
+---
+
+Optimised the `Schema.validate` function to decrease gas use.
diff --git a/docs/pages/store/reference/store-hook.mdx b/docs/pages/store/reference/store-hook.mdx
@@ -1,22 +1,5 @@
 [//]: # "This file is autogenerated, do not change manually"
 
-## Constants
-
-[Git Source](https://github.com/latticexyz/mud/blob/main/packages/store/src/IStoreHook.sol)
-
-### STORE_HOOK_INTERFACE_ID
-
-```solidity
-bytes4 constant STORE_HOOK_INTERFACE_ID = IStoreHook.onBeforeSetRecord.selector ^
-  IStoreHook.onAfterSetRecord.selector ^
-  IStoreHook.onBeforeSpliceStaticData.selector ^
-  IStoreHook.onAfterSpliceStaticData.selector ^
-  IStoreHook.onBeforeSpliceDynamicData.selector ^
-  IStoreHook.onAfterSpliceDynamicData.selector ^
-  IStoreHook.onBeforeDeleteRecord.selector ^
-  IStoreHook.onAfterDeleteRecord.selector;
-```
-
 ## IStoreHook
 
 [Git Source](https://github.com/latticexyz/mud/blob/main/packages/store/src/IStoreHook.sol)