fix(store): slice4 output should be bytes4 [M-03] (#2031)

latticexyz · Jan 3, 2024 · 1b86eac · 1b86eac
1 parent 6db95ce
commit 1b86eac
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/blue-forks-move.md b/.changeset/blue-forks-move.md
@@ -0,0 +1,5 @@
+---
+"@latticexyz/store": patch
+---
+
+Changed the type of the output variable in the `slice4` function to `bytes4`.
diff --git a/packages/store/src/Bytes.sol b/packages/store/src/Bytes.sol
@@ -262,7 +262,7 @@ library Bytes {
    * @return The extracted bytes4 value from the specified position in the bytes32 value.
    */
   function slice4(bytes32 data, uint256 start) internal pure returns (bytes4) {
-    bytes2 output;
+    bytes4 output;
     assembly {
       output := shl(mul(8, start), data)
     }