change order of delegation checks to save gas on successful calls

latticexyz · Aug 29, 2023 · 10ec350 · 10ec350
1 parent dd92ab1
commit 10ec350
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/packages/world/src/Delegation.sol b/packages/world/src/Delegation.sol
@@ -34,13 +34,13 @@ library DelegationInstance {
     bytes32 systemId,
     bytes memory funcSelectorAndArgs
   ) internal returns (bool) {
-    // Early return if there is no valid delegation
-    if (!exists(self)) return false;
-
     // Early return if there is an unlimited delegation
     if (isUnlimited(self)) return true;
 
-    // Call the delegation control contract to check if the delegator has granted access to the delegatee
+    // Early return if there is no valid delegation
+    if (!exists(self)) return false;
+
+    // Call the delegation control contract to check if the delegator has granted access to the delegatee1
     (bool success, bytes memory data) = WorldContextProvider.callWithContext({
       target: Delegation.unwrap(self),
       funcSelectorAndArgs: abi.encodeWithSelector(