Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/milc rhmc cleanup #468

Merged
merged 4 commits into from
May 10, 2016
Merged

Feature/milc rhmc cleanup #468

merged 4 commits into from
May 10, 2016

Conversation

maddyscientist
Copy link
Member

@maddyscientist maddyscientist commented May 10, 2016

This pull request fixes some issues with MILC RHMC that creeped in, mainly due to lacking proper test coverage

  • Fixed compilation bug when Wilson-type fermions are disabled, but staggered are enabled
  • Fixed bugs HISQ force unitarization, and also autotuning now reports bandwidth for this kernel
  • HISQ unitarization force test, CPU reference always done in double precision

@mathiaswagner
Copy link
Member

mathiaswagner commented May 10, 2016

Just a first quick question (I did not yet look at the code in detail): MILC's strategy is to always do unitarization in double. I saw same changes related to precision here and assume they only clean up the code but wanted to make sure we also always do unitarization in double.

@maddyscientist
Copy link
Member Author

Yes we do always do it in double here too. The changes here related to
1.) Make sure it works correctly when fields are in single precision (do computation in double)
2.) For CPU reference, ensure everything is done in double (storage and compute)

@mathiaswagner
Copy link
Member

Thanks. This was what I assumed but was not sure.

@mathiaswagner mathiaswagner merged commit 97672d3 into develop May 10, 2016
@mathiaswagner mathiaswagner deleted the feature/milc-rhmc-cleanup branch May 10, 2016 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants