-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QMP peer-to-peer initialization now uses MPI_Allgather #466
Conversation
… unscalable reduction approach (which was also unreliable due to using float reduction hack).
…e need to exchange hostnames twice. Fixed a bug in QMP device ordinal setting.
Just pushed a commit that also
|
Strict build fails with
|
Looks like the cmake build only does a single GPU build: we should probably test both single and multi GPU builds here. Also, any reason for keeping around the configure style builds now? |
I was up to now unable to get the cmake build to work on Jureca @ JSC... Essentially the problem seems to be related to cmakecache resetting when the compiler is changed, which seems to be necesary because the wrong compiler is "auto-detected". I couldn't get it to compile by editing CMakeCache manually either, so currently I rely on make.inc which seems to work very well. |
@kostrzewa Thanks for that feedback, @mathiaswagner can may be help there as he's the cmake expert 😉. In my comment above I was actually meaning with respect to the Jenkins builds, since Jenkins is presently building both using configure and cmake, which is probably unnecessary. Rest assured, we won't be breaking configure-style builds anytime soon. While I've got your attention @kostrzewa: any outstanding blockers affecting your job throughput on Jureca at the moment? I know the single-GPU issue is outstanding, but hopefully the peer-to-peer enablement has reduced the need for this. |
All WIP. Slowly getting there. On 04.05.2016, at 12:28, maddyscientist <[email protected]mailto:[email protected]> wrote: Fix pushed (was a single-GPU typo). This should be ready for merging now. Looks like the cmake build only does a single GPU build: we should probably test both single and multi GPU builds here. Also, any reason for keeping around the configure style builds now? You are receiving this because you were assigned. NVIDIA GmbH, Wuerselen, Germany, Amtsgericht Aachen, HRB 8361 This email message is for the sole use of the intended recipient(s) and may contain reply email and destroy all copies of the original message. |
Best way to set the compiler is to execute cmake (in a clean directory) using: https://cmake.org/Wiki/CMake_FAQ#How_do_I_use_a_different_compiler.3F From: Bartosz Kostrzewa <[email protected]mailto:[email protected]> @maddyscientisthttps://github.com/maddyscientist Also, any reason for keeping around the configure style builds now? I was up to now unable to get the cmake build to work on Jureca @ JSC... Essentially the problem seems to be related to cmakecache resetting when the compiler is changed, which seems to be necesary because the wrong compiler is "auto-detected". I couldn't get it to compile by editing CMakeCache manually either, so currently I rely on make.inc which seems to work very well. — NVIDIA GmbH, Wuerselen, Germany, Amtsgericht Aachen, HRB 8361 This email message is for the sole use of the intended recipient(s) and may contain reply email and destroy all copies of the original message. |
Acceleration of the peer-to-peer initialization when using QMP: the previous QMP reduction approach was unreliable and unscalable. Instead we just call
MPI_Allgather
directly, which performs much better at large process count.