Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some miscellaneous fixes #1469

Merged
merged 5 commits into from
Jun 6, 2024
Merged

Some miscellaneous fixes #1469

merged 5 commits into from
Jun 6, 2024

Conversation

maddyscientist
Copy link
Member

This is a hotfix PR, nothing too controversial:

  • Fixes warnings with GCC 13 as reported by @bjoo
  • Fixes QUDA_REORDER_LOCATION=CPU (closes dslash_test failing with QUDA_REORDER_LOCATION=CPU #1466)
  • Improves robustness when dealing with nSpin=1 and nSpin=2 fields (only set default gamma basis for nSpin=4 fields to UKQCD basis)
  • Improve user experience with clover fermions: always compute the clover field trace log and report if the trace log is not a number (which is symptomatic of invalid parameters)

@maddyscientist
Fix bug with CPU reordering enabled for copying quark vectors back to…
56f3845 
… the host
@maddyscientist
Some cleanup of copy_color_spinor driver
a759f92
@maddyscientist
In ColorSpinorParam constructor, only set default gamma basis to UQKC…
38821af 
…D if we have nSpin=4 fields
@maddyscientist
Fix compiler warnings with gcc-13
ba2d09d
@maddyscientist
Cleanup of some clover creation handling: we now always compute the t…
d89709d 
…r-log of the clover field, as part of a sanity check that the clover matrix is invertible. This allows us to better adivse the user as opposed to silent Nans in the inverse clover field. We now support computing only the trace log in the cloverInvert routine, and not storing the inverse: this allows us to compute the trace log directly with clover reconstruct switched on
@maddyscientist maddyscientist requested a review from a team as a code owner June 5, 2024 23:55
@maddyscientist maddyscientist mentioned this pull request Jun 6, 2024
Merged
@maddyscientist maddyscientist merged commit 6512dd7 into develop Jun 6, 2024
12 checks passed
@maddyscientist maddyscientist deleted the hotfix/misc branch June 6, 2024 22:31
@bjoo bjoo self-assigned this Jun 11, 2024
bjoo
bjoo reviewed Jun 11, 2024
View reviewed changes
Copy link
Member

@bjoo bjoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess, just the one question about passing the 'false' flag to clover invert rather than true is all I had. The rest look ok for simple visual inspection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoo bjoo bjoo left review comments

@hummingtree hummingtree hummingtree approved these changes

Assignees

@bjoo bjoo

Labels
bug clean-up
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dslash_test failing with QUDA_REORDER_LOCATION=CPU
3 participants
@maddyscientist @bjoo @hummingtree