Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen DWF tolerance by a factor of sqrt(Ls). #1420

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

hummingtree
Copy link
Member

Loosen DWF tolerance by a factor of sqrt(Ls). Domain wall fermions get an additional source of error between the CPU and GPU calculations corresponding to the different summation orders when applying the various 5th dimension operators. O(Ls) number of floating-point numbers are summed together and the error is proportional to sqrt(Ls).

Fixes #1410.

@hummingtree hummingtree requested a review from a team as a code owner December 6, 2023 21:10
@maddyscientist
Copy link
Member

@jcosborn can you test this please?

Copy link
Contributor

@jcosborn jcosborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this seems to have fixed the errors. Thanks!

@maddyscientist maddyscientist merged commit a24bcfa into develop Dec 7, 2023
12 checks passed
@maddyscientist maddyscientist deleted the hotfix/dwf-tol branch December 7, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mild failures in some DW ctests
3 participants