Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more ROCm versions to CI #1419

Merged
merged 3 commits into from
Dec 1, 2023
Merged

Add more ROCm versions to CI #1419

merged 3 commits into from
Dec 1, 2023

Conversation

dmcdougall
Copy link
Contributor

Let's see if this works... :)

@dmcdougall dmcdougall requested a review from a team as a code owner November 30, 2023 19:11
@maddyscientist
Copy link
Member

@dmcdougall I see the inline assembly warnings are now gone with 5.6. Is there any reason to keep around 5.5 or can we dump this and make the builds STRICT now?

@dmcdougall
Copy link
Contributor Author

Is there any reason to keep around 5.5 or can we dump this and make the builds STRICT now?

You took the wind out of my sails :)

That is indeed my next step, I just wanted to sanity check the multiple version infrastructure did what I expected it to do.

Don't merge this yet; I'll update this PR with more commits.

@dmcdougall
Turn off 5.5.0 and do STRICT builds
926a895
@dmcdougall
Fix up action name
8f6c951 
I expect this change will make it so that both the cuda and rocm builds
can all be viewed inline in the GitHub Actions web interface.
@dmcdougall
Copy link
Contributor Author

@maddyscientist Can you kick off another build please?

@dmcdougall
Copy link
Contributor Author

Hmmm, these STRICT builds succeeded but there are still warnings. I'll dig.

@dmcdougall
Copy link
Contributor Author

Oh this turns off the error (STRICT users -Werror). It doesn't turn off the warning.

@maddyscientist
Copy link
Member

@dmcdougall good to merge now from your point of view?

@dmcdougall
Copy link
Contributor Author

Yep. Thanks.

@maddyscientist maddyscientist merged commit e46c1ed into lattice:develop Dec 1, 2023
4 checks passed
@dmcdougall dmcdougall deleted the add_rocm_ci_versions branch December 1, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maddyscientist maddyscientist maddyscientist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmcdougall @maddyscientist