Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we eliminate make.inc.example? #9

Closed
rbabich opened this issue Feb 15, 2011 · 6 comments
Closed

Should we eliminate make.inc.example? #9

rbabich opened this issue Feb 15, 2011 · 6 comments
Labels

Comments

@rbabich
Copy link
Member

rbabich commented Feb 15, 2011

There seems to be increasing danger of make.in and make.inc.example getting out of sync. If there's consensus, I'd be in favor of going over completely to Balint's autoconf approach.

@maddyscientist
Copy link
Member

You've got my vote.

@gshi
Copy link
Member

gshi commented Feb 16, 2011

Out of sync is not big of deal in the devel branch. We only need to make sure it is synced when we make a release.

@bjoo
Copy link
Member

bjoo commented Feb 18, 2011

Syncing is easy in principle, just do a build to test something and then copy the make inc over. However, it is a step that we're always likely to forget to do :(

Do we want to make a 'release checklist' that we go through prior to a release?
(even if we don't enforce it rigorously it may be useful to aid our release process)

@rbabich
Copy link
Member Author

rbabich commented Feb 18, 2011

I have a release checklist that I'll update. Maybe I should post it to the wiki (on github)?

@bjoo
Copy link
Member

bjoo commented Feb 20, 2011

It can also be kept under revision control :)

@maddyscientist
Copy link
Member

I have decided to make a unilateral decision and remove make.in.example from the library. With the increasing number of compilation options which have dependencies, e.g., I've just added QIO support which requires QMP, I think maintaining make.inc.example and make.inc is both a waste of resources, and can lead to compilation errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants